PC-1515: Fix for loft insulation error on check answers page #416
+85
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdgage
requested changes
Dec 18, 2024
| @@ -489,6 +492,7 @@ | |||
| loft_insulation_field_no_insulation: _("I have no loft insulation"), | |||
| loft_insulation_field_dont_know: _("I do not know"), | |||
| loft_insulation_field_no_loft: _("No loft"), | |||
| "I have up to 100mm of loft insulation": _("I have less than or equal to 100mm of loft insulation"), | |||
There was a problem hiding this comment.
I think put the comment on top of here and add a blank line if the formatter allows it - would more clearly delineate between real answers and the ones kept for backwards-compatibility
There was a problem hiding this comment.
I'd rather keep the main comment on the map as it applies to all pages in general, have added one to this line too. no newline allowed alas
this avoids a key not found error for old users
samyou-softwire
force-pushed
the
PC-1515-loft-insulation-error-on-check-answers-page
branch
from
199e124 to
3e577f4
Compare
jdgage
approved these changes
Dec 19, 2024
samyou-softwire
deleted the
PC-1515-loft-insulation-error-on-check-answers-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket
Description
add old copy to check_your_answers_options_map. this avoids a key not found error for old users
Checklist
make extract-translations